Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CH-397] support posexplode/sequence functions #399

Merged
merged 24 commits into from
Apr 12, 2023
Merged

[CH-397] support posexplode/sequence functions #399

merged 24 commits into from
Apr 12, 2023

Conversation

taiyang-li
Copy link

@taiyang-li taiyang-li commented Apr 4, 2023 •
edited
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

I check-pick prs from CH because posexplode/sequence/mapFromArrays functions need them:

This pr also fix #410

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

@taiyang-li
Copy link
Author

test this please with 1281

@taiyang-li taiyang-li marked this pull request as draft April 4, 2023 09:48
@taiyang-li taiyang-li changed the title [CH-397] support spark sequence function [CH-397] support posexplode/sequence/mapFromArrays functions Apr 7, 2023
@taiyang-li taiyang-li changed the title [CH-397] support posexplode/sequence/mapFromArrays functions [CH-397] support posexplode/sequence functions Apr 7, 2023
@taiyang-li taiyang-li marked this pull request as ready for review April 7, 2023 09:54
@taiyang-li
Copy link
Author

test this please with 1281

@taiyang-li
Copy link
Author

performance tests

select count(1) from (select l_orderkey, posexplode(array('1', '2')), l_suppkey from lineitem)  ;

set spark.gluten.sql.columnar.generate=true;
1 row selected (0.227 seconds) 

set spark.gluten.sql.columnar.generate=false;
1 row selected (1.106 seconds)

@taiyang-li
Copy link
Author

test this please with 1281

2 similar comments
@taiyang-li
Copy link
Author

test this please with 1281

@taiyang-li
Copy link
Author

test this please with 1281

@taiyang-li
Copy link
Author

test this please with 1281

@zzcclp zzcclp requested a review from liuneng1994 April 12, 2023 01:04
liuneng1994
liuneng1994 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 0417ceb into Kyligence:clickhouse_backend Apr 12, 2023
@taiyang-li taiyang-li mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuneng1994 liuneng1994 liuneng1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coredump when ut exit, seems related to resource release of BroadCastJoinBuilder
4 participants
@taiyang-li @kyligence-git @liuneng1994 @rschu1ze